Issue #100: Fix User.manager_user_id type: change from StrictStr to StrictInt#101
Merged
Subterrane merged 1 commit intoonelogin:mainfrom Sep 2, 2025
Merged
Conversation
amnon-jazz
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Issue #100 by correcting a type inconsistency in the User model. The change updates the manager_user_id field from StrictStr to StrictInt to properly align with OneLogin's User ID format expectations.
- Updated
User.manager_user_idfield type fromStrictStrtoStrictInt
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User.manager_user_idfromStrictStrtoStrictInt.This pull request makes a small update to the
Usermodel to improve type consistency. The most important change is updating the type of themanager_user_idfield fromStrictStrtoStrictInt, ensuring that it matches the expected format for OneLogin User IDs.